zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bothejjms <...@git.apache.org>
Subject [GitHub] zookeeper pull request #563: Fix for ZOOKEEPER-3072
Date Mon, 09 Jul 2018 10:59:50 GMT
Github user bothejjms commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/563#discussion_r200961680
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -1124,6 +1124,7 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer)
throws IOE
                 }
                 return;
             } else {
    +            cnxn.incrOutstandingRequests(h);
    --- End diff --
    
    hmm right. That return was not there in 3.5.3 where I have spotted the issue. I have missed
it when I have moved my change to master.
    I see ZOOKEEPER-2785 introduced it. I will update my pr and move incr to the else branch
to avoid sasl throttling.


---

Mime
View raw message