zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #563: Fix for ZOOKEEPER-3072
Date Mon, 09 Jul 2018 10:36:49 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/563#discussion_r200956044
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -1124,6 +1124,7 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer)
throws IOE
                 }
                 return;
             } else {
    +            cnxn.incrOutstandingRequests(h);
    --- End diff --
    
    I have 2 observations here which probably don't make a big difference but might worse
to consider.
    - First, the return statements in the if branches are not required anymore, because there's
no more statement at the end of the method anymore,
    - Second, moving `cnxn.incrOutstandingRequests(h)` here means that from now on you'll
trigger throttling for `sasl` requests too, which was not the case previously. Same for `auth`
packets which I believe was done intentionally.


---

Mime
View raw message