From dev-return-70667-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jun 18 14:53:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5201D180663 for ; Mon, 18 Jun 2018 14:53:03 +0200 (CEST) Received: (qmail 55755 invoked by uid 500); 18 Jun 2018 12:53:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 55744 invoked by uid 99); 18 Jun 2018 12:53:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jun 2018 12:53:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C42C6C697C for ; Mon, 18 Jun 2018 12:53:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id d15lxiFRLADq for ; Mon, 18 Jun 2018 12:53:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E400F5F18A for ; Mon, 18 Jun 2018 12:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6CE22E0361 for ; Mon, 18 Jun 2018 12:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2417F2183B for ; Mon, 18 Jun 2018 12:53:00 +0000 (UTC) Date: Mon, 18 Jun 2018 12:53:00 +0000 (UTC) From: "Andor Molnar (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-3065) Refactor existing reconfig tests in StaticHostProviderTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-3065: ------------------------------------ Description: The following issues would be nice to address: * Tests cover addresses with IP addresses only, a few of them test unresolved hostnames, but ideal would be to create Test parameters and run all tests for both cases, * Test methods should be split into multiple to cover one test case / test method, * Style: instead of assertTrue(a < b), we should use assertThat(b, greaterThan(a)) * Extract redundant code snippets into methods was: The following issues would be nice to address: * Tests over addresses with IP addresses only, a few of them test unresolved hostnames, but ideal would be to create Test parameters and run all tests for both cases, * Test methods should be split into multiple to cover one test case / test method, * Style: instead of assertTrue(a < b), we should use assertThat(b, greaterThan(a)) * Extract redundant code snippets into methods > Refactor existing reconfig tests in StaticHostProviderTest > ---------------------------------------------------------- > > Key: ZOOKEEPER-3065 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3065 > Project: ZooKeeper > Issue Type: Test > Components: tests > Affects Versions: 3.6.0 > Reporter: Andor Molnar > Assignee: Andor Molnar > Priority: Minor > Fix For: 3.6.0 > > > The following issues would be nice to address: > * Tests cover addresses with IP addresses only, a few of them test unresolved hostnames, but ideal would be to create Test parameters and run all tests for both cases, > * Test methods should be split into multiple to cover one test case / test method, > * Style: instead of assertTrue(a < b), we should use assertThat(b, greaterThan(a)) > * Extract redundant code snippets into methods -- This message was sent by Atlassian JIRA (v7.6.3#76005)