From dev-return-70358-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Jun 5 17:06:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E506D180625 for ; Tue, 5 Jun 2018 17:06:07 +0200 (CEST) Received: (qmail 58177 invoked by uid 500); 5 Jun 2018 15:06:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 58030 invoked by uid 99); 5 Jun 2018 15:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2018 15:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6682D1A29D7 for ; Tue, 5 Jun 2018 15:06:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id VtkCSDkGacPq for ; Tue, 5 Jun 2018 15:06:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 698605F542 for ; Tue, 5 Jun 2018 15:06:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8DE34E00FC for ; Tue, 5 Jun 2018 15:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 18A1121096 for ; Tue, 5 Jun 2018 15:06:00 +0000 (UTC) Date: Tue, 5 Jun 2018 15:06:00 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16501920#comment-16501920 ]=20 Michael Han commented on ZOOKEEPER-3056: ---------------------------------------- cc [~nixon], [~breed]=C2=A0who introduced the check in ZOOKEEPER-2325. What do you guys think about this? Do you always have valid snapshot files = in your deployment? > Fails to load database with missing snapshot file but valid transaction l= og file > -------------------------------------------------------------------------= ------- > > Key: ZOOKEEPER-3056 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3056 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.3, 3.5.4 > Reporter: Michael Han > Priority: Critical > > [An issue|https://lists.apache.org/thread.html/cc17af6ef05d42318f74148f1a= 704f16934d1253f1472cccc1a93b4b@%3Cdev.zookeeper.apache.org%3E] was reported= when a user failed to upgrade from 3.4.10 to 3.5.4 with missing snapshot f= ile. > The code complains about missing snapshot file is [here|https://github.co= m/apache/zookeeper/blob/release-3.5.4/src/java/main/org/apache/zookeeper/se= rver/persistence/FileTxnSnapLog.java#L206] which is introduced as part of Z= OOKEEPER-2325. > With this check, ZK will not load the db without a snapshot file, even th= e transaction log files are present and valid. This could be a problem for = restoring a ZK instance which does not have a snapshot file but have a soun= d state (e.g. it crashes before being able to take the first snap shot with= a large snapCount parameter configured). -- This message was sent by Atlassian JIRA (v7.6.3#76005)