From dev-return-70723-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Jun 20 20:09:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E59C9180648 for ; Wed, 20 Jun 2018 20:09:54 +0200 (CEST) Received: (qmail 15422 invoked by uid 500); 20 Jun 2018 18:09:48 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 15411 invoked by uid 99); 20 Jun 2018 18:09:48 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2018 18:09:48 +0000 Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id E4EBBCC5 for ; Wed, 20 Jun 2018 18:09:47 +0000 (UTC) Received: by mail-wm0-f49.google.com with SMTP id z6-v6so249844wma.0 for ; Wed, 20 Jun 2018 11:09:47 -0700 (PDT) X-Gm-Message-State: APt69E0T3y2xg7nxYNY1Hd7ep+8O4LYPRfU67EAtDf/oGK/8LV8mp4pe 8OssiiDwr4h+R6fYTRBy+F2TOy6yveXaIsuVw2I= X-Google-Smtp-Source: ADUXVKLFIOIiOKREYimtpK8RlIqq0vKGbJtZDxO5bu+vUfycmBNRkWAWWYsaCELljC1gWPCS8XdqVu/eRR63kPjdkfw= X-Received: by 2002:a1c:328a:: with SMTP id y132-v6mr2492342wmy.70.1529518187030; Wed, 20 Jun 2018 11:09:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Patrick Hunt Date: Wed, 20 Jun 2018 11:09:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0 To: DevZooKeeper Content-Type: multipart/alternative; boundary="000000000000373505056f16b4bb" --000000000000373505056f16b4bb Content-Type: text/plain; charset="UTF-8" Hm. Not directly on point but related - should we move off auto* tools at some point and just use cmake? (which is already in the codebase) Or some other option? Patrick On Wed, Jun 20, 2018 at 11:05 AM Andor Molnar wrote: > "When is pkg-config needed?" > > Both. You need the macro to generate ./configure and you need pkg-config > and cppunit.pc (part of cppunit package) to compile the tests. > > "Do we already do something special like generate the configure script and > ship that as part of the release?" > > That's correct. We ship the generated ./configure script and Makefile.in in > the release artifact. > > Andor > > > > > On Wed, Jun 20, 2018 at 7:38 PM, Patrick Hunt wrote: > > > When is pkg-config needed? If you want to compile from source or if you > > want to compile from the release artifact? Do we already do something > > special like generate the configure script and ship that as part of the > > release? > > > > Patrick > > > > On Fri, Jun 8, 2018 at 6:44 AM Andor Molnar wrote: > > > > > This PR is also related: > > > > > > https://github.com/apache/zookeeper/pull/362 > > > > > > Andor > > > > > > > > > > > > On Fri, Jun 8, 2018 at 3:18 PM, Andor Molnar > wrote: > > > > > > > Hi devs, > > > > > > > > I'm having problems resolving the issue mentioned in this Jira and > need > > > > some feedback from you: > > > > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3034 > > > > > > > > In a nutshell the situation with *cppunit* is as follows: > > > > LibreOffice team confirmed that from version *1.14.0* they will no > > longer > > > > ship m4 macro definitions in cppunit releases. They encourage > everybody > > > to > > > > use *pkg-config* instead in order to generate configure script and > > > > Makefile. By the way, this is not a new thing, it was supported even > > > before > > > > 1.14.0. So basically, they no longer support both tools, only > > > pkg-config. > > > > > > > > So, in order to support building and running C++ tests on recent > > > > distributions with cppunit-1.14.0 like Ubuntu 18.04, Fedora, etc., we > > > have > > > > to switch to *pkg-config*. > > > > > > > > *Backward compatibility* > > > > pkg-config is going to be a new dependency of the C client which we > > need > > > > to add to the documentation near to autoconf 2.59 requirement. On the > > > > flipside we can remove the requirement of cppunit.m4. > > > > > > > > Another thing we can do is to maintain two different configure.ac > > > scripts > > > > from now on: one for cppunit.m4 and another one for pkg-config which > is > > > > going to be the default. We also have to describe in the > documentation > > > why > > > > we made that change and how to revert to the m4 version if needed. > > > > > > > > The way it's currently implemented in the following pull request has > > been > > > > tested and works on Ubuntu 14.04, 18.04 and CentOS 7 as long as > > > pkg-config > > > > is installed. > > > > > > > > https://github.com/apache/zookeeper/pull/528 > > > > > > > > Please share your thoughts and review the changes. > > > > > > > > Thanks, > > > > Andor > > > > > > > > > > > > > > > > > > --000000000000373505056f16b4bb--