From dev-return-71013-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Thu Jun 28 14:13:58 2018
Return-Path: <dev-return-71013-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 0F3AE180662
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 28 Jun 2018 14:13:57 +0200 (CEST)
Received: (qmail 51290 invoked by uid 500); 28 Jun 2018 12:13:57 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 51279 invoked by uid 99); 28 Jun 2018 12:13:56 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jun 2018 12:13:56 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 06082E0A9F; Thu, 28 Jun 2018 12:13:55 +0000 (UTC)
From: a470577391 <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-553-zookeeper@git.apache.org>
In-Reply-To: <git-pr-553-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #553: continue can be replaced with break
Content-Type: text/plain
Message-Id: <20180628121356.06082E0A9F@git1-us-west.apache.org>
Date: Thu, 28 Jun 2018 12:13:55 +0000 (UTC)

Github user a470577391 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/553#discussion_r198817324
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -254,7 +254,7 @@ public synchronized boolean append(TxnHeader hdr, Record txn)
             for (File f : files) {
                 long fzxid = Util.getZxidFromName(f.getName(), LOG_FILE_PREFIX);
                 if (fzxid > snapshotZxid) {
    -                continue;
    +                break;
                 }
                 // the files
    --- End diff --
    
    2. ZooKeeper runs in Java, release 1.8 or greater :smile:


---