From dev-return-70675-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jun 18 16:39:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD5F9180663 for ; Mon, 18 Jun 2018 16:39:08 +0200 (CEST) Received: (qmail 65153 invoked by uid 500); 18 Jun 2018 14:39:07 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 65142 invoked by uid 99); 18 Jun 2018 14:39:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jun 2018 14:39:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E2F55DFC43; Mon, 18 Jun 2018 14:39:06 +0000 (UTC) From: timothyjward To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c... Content-Type: text/plain Message-Id: <20180618143906.E2F55DFC43@git1-us-west.apache.org> Date: Mon, 18 Jun 2018 14:39:06 +0000 (UTC) Github user timothyjward commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r196102971 --- Diff: src/java/main/org/apache/zookeeper/Watcher.java --- @@ -84,7 +84,14 @@ * client connection (the session) is no longer valid. You must * create a new client connection (instantiate a new ZooKeeper * instance) if you with to access the ensemble. */ - Expired (-112); + Expired (-112), + + /** + * The client has been closed. This state is never generated by + * the server, but is generated locally when a client calls + * {@link ZooKeeper#close()} or {@link ZooKeeper#close(int)} + */ + Closed (-2); --- End diff -- My understanding was that a negative value would be preferred for an event which didn't originate from the server, but I don't mind changing it. ---