From dev-return-70463-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Sun Jun 10 09:19:08 2018
Return-Path: <dev-return-70463-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id D101318062B
	for <archive-asf-public@cust-asf.ponee.io>; Sun, 10 Jun 2018 09:19:07 +0200 (CEST)
Received: (qmail 6748 invoked by uid 500); 10 Jun 2018 07:19:06 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 6736 invoked by uid 99); 10 Jun 2018 07:19:05 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jun 2018 07:19:05 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 58FE4E09EC; Sun, 10 Jun 2018 07:19:05 +0000 (UTC)
From: maoling <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-539-zookeeper@git.apache.org>
In-Reply-To: <git-pr-539-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #539: ZOOKEEPER-3058: Do length check first before ac...
Content-Type: text/plain
Message-Id: <20180610071905.58FE4E09EC@git1-us-west.apache.org>
Date: Sun, 10 Jun 2018 07:19:05 +0000 (UTC)

Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/539#discussion_r194248152
  
    --- Diff: src/java/main/org/apache/jute/Utils.java ---
    @@ -268,15 +268,14 @@ static String toCSVBuffer(byte barr[]) {
             return stream.toByteArray();
         }
         public static int compareBytes(byte b1[], int off1, int len1, byte b2[], int off2, int len2) {
    -        int i;
    -        for(i=0; i < len1 && i < len2; i++) {
    +        if (len1 != len2) {
    +            return len1 < len2 ? -1 : 1;
    +        }
    +        for(int i=0; i < len1; i++) {
                 if (b1[off1+i] != b2[off2+i]) {
    --- End diff --
    
    no a issue?
    This function is for comparison byte one by one.
    Some UT for understanding:
    zbcd : abcde  --> 1
    abcd :  abce --> 1
    abcd :  abca --> -1
    abcd :  abcde --> 1
    abcd :  abc --> -1


---