zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3063) Track outstanding changes with ArrayDeque
Date Fri, 15 Jun 2018 08:05:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513506#comment-16513506
] 

Hudson commented on ZOOKEEPER-3063:
-----------------------------------

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #62 (See [https://builds.apache.org/job/ZooKeeper-trunk/62/])
ZOOKEEPER-3063: Track outstanding changes with ArrayDeque (hanm: rev d6490d590725345638b5973a97e6e8d8bee67d22)
* (edit) src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
* (edit) src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java


> Track outstanding changes with ArrayDeque
> -----------------------------------------
>
>                 Key: ZOOKEEPER-3063
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3063
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Yisong Yue
>            Assignee: Yisong Yue
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Outstanding changes are tracked with an ArrayList, which has O(N) remove from head (and
possibly add) performance. This means that as we get further behind, we will slow down the
processing of outstanding changes, which would make us get further behind.
>  We should switch to using ArrayDeque which achieves O(1) add and remove on both ends,
which should result in much happiness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message