zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition
Date Tue, 26 Jun 2018 11:45:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523606#comment-16523606
] 

Hadoop QA commented on ZOOKEEPER-2873:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//console

This message is automatically generated.

> print error and/or abort on invalid server definition
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-2873
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10
>            Reporter: Christopher Smith
>            Assignee: Norbert Kalmar
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put some lines
like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election components
fought over the single port. Since a configuration of this case is *always* an error, I suggest
that it would be sensible to abort the server startup if an entry is found with the same port
for both client and election. (Logging the error explicitly without shutting down is less
helpful because of how fast the logs pile up.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message