zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Nixon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2421) testSessionReuse is commented out
Date Mon, 11 Jun 2018 04:44:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507670#comment-16507670

Brian Nixon commented on ZOOKEEPER-2421:

[~prasanthm] This is an ancient test so someone who was involved in the project pre-2008 may
have to provide some context around it and it's purpose. That's not me but I can say a bit
after looking at the SessionTest file.

Session id reuse as such is not allowed in current ZooKeeper. There are two ways that this
test could now go. One is to make sure that the second client can *not* use that session id,
that there is no state retained server-side that allows a reuse after close. The second is
to change it to a session moved style test but I think this scenario is already covered in
testSession and testSessionMove.

If you don't see a useful way of reintroducing the test after a bit of poking, I'd say to
put up a pull request removing it entirely and see if it gets accepted - it simply may no
longer be meaningful.

> testSessionReuse is commented out
> ---------------------------------
>                 Key: ZOOKEEPER-2421
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2421
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Prasanth Mathialagan
>            Priority: Major
> This test case in SessionTest:
> {noformat}
>    testSessionReuse
> {noformat}
> is commented out.

This message was sent by Atlassian JIRA

View raw message