zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From enixon <...@git.apache.org>
Subject [GitHub] zookeeper pull request #547: ZOOKEEPER-3068: Improve C client logging of IPv...
Date Mon, 25 Jun 2018 20:09:58 GMT
Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/547#discussion_r197925813
  
    --- Diff: src/c/src/zookeeper.c ---
    @@ -4358,7 +4358,9 @@ static const char* format_endpoint_info(const struct sockaddr_storage*
ep)
     {
         static char buf[128] = { 0 };
         char addrstr[128] = { 0 };
    +    const char *fmtstring;
         void *inaddr;
    +    int inet6 = 0;  // poor man's boolean
    --- End diff --
    
    Sounds good to me, I'll rework that variable.


---

Mime
View raw message