zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...
Date Mon, 25 Jun 2018 15:10:21 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/546#discussion_r197833005
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java ---
    @@ -79,4 +80,27 @@ public void testClientAddress() throws Exception {
             cnxnFactory.shutdown();
         }
     
    +    @Test
    +    @SuppressWarnings("unchecked")
    +    public void testIsLeader() throws Exception {
    --- End diff --
    
    - This is a `QuorumPeer` test, move it to `QuorumPeerTest` class please.
    - These are actually 3 tests together, split them into 3 methods please.


---

Mime
View raw message