zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivankelly <...@git.apache.org>
Subject [GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...
Date Mon, 25 Jun 2018 11:52:37 GMT
Github user ivankelly commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/546#discussion_r197768450
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
    @@ -36,7 +36,7 @@ public void testGetClientAddressShouldReturnEmptyStringWhenClientAddressIsNull()
             InetSocketAddress peerCommunicationAddress = null;
             // Here peerCommunicationAddress is null, also clientAddr is null
             QuorumServer peer = new QuorumServer(1, peerCommunicationAddress);
    -        RemotePeerBean remotePeerBean = new RemotePeerBean(peer);
    +        RemotePeerBean remotePeerBean = new RemotePeerBean(null /*QuorumPeer*/, peer);
    --- End diff --
    
    Not everyone uses an IDE, and code review happens on github which doesn't give hints about
this stuff.


---

Mime
View raw message