zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
Date Sun, 24 Jun 2018 09:43:15 GMT
Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/548#discussion_r197633888
  
    --- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java ---
    @@ -60,4 +60,25 @@ static public String getClientConfigStr(String configData) {
             }
             return version + " " + sb.toString();
         }
    +
    +    public static String[] splitServerConfig(String s)
    +        throws ConfigException
    +    {
    +        /* Does it start with an IPv6 literal? */
    --- End diff --
    
    good method.this annotation's answer is sure(grin)
    
    
    



---

Mime
View raw message