zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #542: [ZOOKEEPER-3060] Logging the server local port ...
Date Mon, 18 Jun 2018 12:44:09 GMT
Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/542#discussion_r196062698
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
    @@ -686,6 +686,8 @@ public void configure(InetSocketAddress addr, int maxcc, boolean secure)
throws
             LOG.info("binding to port " + addr);
             ss.socket().bind(addr);
             ss.configureBlocking(false);
    +        int port = ss.socket().getLocalPort();
    +        LOG.info("bound to port " + port);
    --- End diff --
    
    Just a nitpick: why create a variable for the port?


---

Mime
View raw message