zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #544: ZOOKEEPER-3009 : fix the related bugs in branch...
Date Mon, 18 Jun 2018 03:35:09 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/544#discussion_r195958750
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
    @@ -165,9 +168,13 @@ public void removeCnxn(NIOServerCnxn cnxn) {
                 }
     
                 synchronized (ipMap) {
    -                Set<NIOServerCnxn> s =
    -                        ipMap.get(cnxn.getSocketAddress());
    -                s.remove(cnxn);
    +                InetAddress addr = cnxn.getSocketAddress();
    +            	if (addr != null) {
    --- End diff --
    
    coding style issue: need one more space before the if statement so it aligns with previous
statement. Other than this, patch looks good.


---

Mime
View raw message