zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Fri, 15 Jun 2018 15:36:49 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r195779559
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -64,6 +66,8 @@
     
         protected InetSocketAddress clientPortAddress;
         protected InetSocketAddress secureClientPortAddress;
    +    protected boolean sslQuorum = false;
    +    protected boolean shouldUsePortUnification = false;
    --- End diff --
    
    @breed Do you think it would be useful to set these properties via JMX or should it be
just read-only?
    
    I think it would be also great to expose the properties via Jetty `stat` command as well.
It makes it easier to figure out which instance is already SSL/Unification enabled.


---

Mime
View raw message