zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivmaykov <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Sat, 09 Jun 2018 17:43:29 GMT
Github user ivmaykov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r194233639
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -292,8 +298,20 @@ protected void connectToLeader(InetSocketAddress addr, String hostname)
                     sock.getInputStream()));
             bufferedOutput = new BufferedOutputStream(sock.getOutputStream());
             leaderOs = BinaryOutputArchive.getArchive(bufferedOutput);
    -    }   
    -    
    +    }
    +
    +    private void createSocket() throws X509Exception, IOException {
    --- End diff --
    
    minor style nit: prefer you return the socket from this method and assign to `sock` in
the caller.


---

Mime
View raw message