zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper issue #533: ZOOKEEPER-2989:IPv6 literal address causes problems fo...
Date Mon, 04 Jun 2018 10:11:57 GMT
Github user nkalmar commented on the issue:

    https://github.com/apache/zookeeper/pull/533
  
    I agree with @anmolnar in that the methods are a little robust and test multiple things.
Whether it should be refactored whenever we touch a unit test, that's a tough question. 
    
    But I also agree with what @maoling  said about the inner class: generally, unit tests
should not be separated when dealing with inner classes, as they only makes sense in the context
of the outer class.
    
    Anyway, the change looks good to me! 


---

Mime
View raw message