zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...
Date Mon, 04 Jun 2018 05:41:35 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/534#discussion_r192630642
  
    --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java ---
    @@ -314,7 +340,7 @@ public InetSocketAddress next(long spinDelay) {
                     addr = nextHostInReconfigMode();
                     if (addr != null) {
                     	currentIndex = serverAddresses.indexOf(addr);
    -                	return addr;                
    +                	return resolve(addr);
    --- End diff --
    
    Can you do some test to find out performance/latency of resolving an addr? If it's costly,
maybe we should cache the resolved one instead of resolve it every time.


---

Mime
View raw message