From dev-return-69519-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed May 9 00:09:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9D2AE18063B for ; Wed, 9 May 2018 00:09:56 +0200 (CEST) Received: (qmail 53497 invoked by uid 500); 8 May 2018 22:09:55 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 53480 invoked by uid 99); 8 May 2018 22:09:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 22:09:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C8669DFF7E; Tue, 8 May 2018 22:09:54 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org Message-ID: Subject: [GitHub] zookeeper pull request #514: ZOOKEEPER-3012. Fix unit test: testDataDirAndDa... Content-Type: text/plain Date: Tue, 8 May 2018 22:09:54 +0000 (UTC) GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/514 ZOOKEEPER-3012. Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders A little bit more than just fixing the hardcoded folder names. Because the original issue was only on the 3.4 branch, the unit test has also been added to that branch only. In this PR I add the fixed version of test to the master branch. Should be committed to 3.5 as well and I'll create a separate PR for 3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3012 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/514.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #514 ---- commit 15ff7951701a55d2b9e94af6d4dd73288a2c51a4 Author: Andor Molnar Date: 2018-05-08T22:04:23Z ZOOKEEPER-3012. Added unit test to validate dataDir and dataLogDir params ---- ---