From dev-return-70160-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon May 28 16:11:34 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 203C3180676 for ; Mon, 28 May 2018 16:11:33 +0200 (CEST) Received: (qmail 28989 invoked by uid 500); 28 May 2018 14:11:31 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 27985 invoked by uid 99); 28 May 2018 14:11:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 May 2018 14:11:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id BE46BE0E1D; Mon, 28 May 2018 14:11:30 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log Content-Type: text/plain Message-Id: <20180528141130.BE46BE0E1D@git1-us-west.apache.org> Date: Mon, 28 May 2018 14:11:30 +0000 (UTC) Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/307#discussion_r191199674 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -21,17 +21,33 @@ import org.apache.zookeeper.common.Time; +import org.apache.zookeeper.server.quorum.QuorumPeerConfig; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Timer; +import java.util.TimerTask; +import java.util.concurrent.atomic.AtomicReference; /** * Basic Server Statistics */ public class ServerStats { + private static final Logger LOG = LoggerFactory.getLogger(ServerStats.class); + private long packetsSent; private long packetsReceived; private long maxLatency; private long minLatency = Long.MAX_VALUE; private long totalLatency = 0; private long count = 0; + private long numRequestsAboveThresholdTime = 0; + + final static long requestWarnThresholdMs = QuorumPeerConfig.getRequestWarnResponseThresholdMs(); + final static Timer timer = new Timer(); --- End diff -- Have you considered using `ScheduledExecutorService` instead? https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ScheduledExecutorService.html ---