From dev-return-69467-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Mon May  7 17:22:57 2018
Return-Path: <dev-return-69467-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 51D49180648
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  7 May 2018 17:22:57 +0200 (CEST)
Received: (qmail 5614 invoked by uid 500); 7 May 2018 15:22:51 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 5599 invoked by uid 99); 7 May 2018 15:22:50 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2018 15:22:50 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A51CDE09F4; Mon,  7 May 2018 15:22:50 +0000 (UTC)
From: rakeshadr <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-377-zookeeper@git.apache.org>
In-Reply-To: <git-pr-377-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...
Content-Type: text/plain
Message-Id: <20180507152250.A51CDE09F4@git1-us-west.apache.org>
Date: Mon,  7 May 2018 15:22:50 +0000 (UTC)

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/377#discussion_r186422920
  
    --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
    @@ -950,6 +952,39 @@ server.3=zoo3:2888:3888</programlisting>
                 </listitem>
               </varlistentry>
     
    +          <varlistentry>
    +            <term>zookeeper.extendedTypesEnabled</term>
    +
    +            <listitem>
    +                <para>(Java system property only: <emphasis
    +                    role="bold">zookeeper.extendedTypesEnabled</emphasis>)</para>
    +
    +              <para><emphasis role="bold">New in 3.5.4, 3.6.0:</emphasis> Define to "true" to enable
    +              extended features such as the creation of <ulink url="zookeeperProgrammers.html#TTL+Nodes">TTL Nodes</ulink>.
    +              They are disabled by default. IMPORTANT: when enabled server IDs must
    +              be less than 255 due to internal limitations.
    +              </para>
    +            </listitem>
    +          </varlistentry>
    +
    +          <varlistentry>
    +            <term>zookeeper.emulate353TTLNodes</term>
    +
    +            <listitem>
    +                <para>(Java system property only: <emphasis
    +                    role="bold">zookeeper.emulate353TTLNodes</emphasis>)</para>
    +
    +              <para><emphasis role="bold">New in 3.5.4, 3.6.0:</emphasis> Due to
    +                <ulink url="https://issues.apache.org/jira/browse/ZOOKEEPER-2901">ZOOKEEPER-2901</ulink> TTL nodes
    +                created in version 3.5.3 are not supported in 3.5.4/3.6.0. However, a workaround is provided via the
    +                zookeeper.emulate353TTLNodes system property. If you used TTL nodes in ZooKeeper 3.5.3 and need to maintain
    +                compatibility set <emphasis role="bold">zookeeper.emulate353TTLNodes</emphasis> to "true" in addition to
    +                <emphasis role="bold">zookeeper.extendedTypesEnabled</emphasis>. NOTE: due to the bug, server IDs
    +                must be 127 or less. Additionally, the maximum support TTL value is 1099511627775 which is smaller
    +                than what was allowed in 3.5.3 (1152921504606846975)</para>
    --- End diff --
    
    I think, the max limit "1152921504606846975" was not documented in 3.5.3 doc. Please add unit `milliseconds` to the value. Also, please take care @phunt's comment.


---