zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2097) Clarify security requirement for Exists request
Date Thu, 10 May 2018 20:40:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471071#comment-16471071
] 

Hadoop QA commented on ZOOKEEPER-2097:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688439/ZOOKEEPER-2097.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3674//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3674//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3674//console

This message is automatically generated.

> Clarify security requirement for Exists request
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-2097
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2097
>             Project: ZooKeeper
>          Issue Type: Task
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Ian Dimayuga
>            Assignee: Ian Dimayuga
>            Priority: Minor
>             Fix For: 3.6.0, 3.5.5
>
>         Attachments: ZOOKEEPER-2097.patch
>
>
> According to the [Programmer's Guide|http://zookeeper.apache.org/doc/current/zookeeperProgrammers.html]:
> bq. Everyone implicitly has LOOKUP permission. This allows you to stat a node, but nothing
more. (The problem is, if you want to call zoo_exists() on a node that doesn't exist, there
is no permission to check.)
> This implies that Exists has no security requirement, so the existing comment in FinalRequestProcessor
> {code}// TODO we need to figure out the security requirement for this!{code}
> can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message