zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional
Date Thu, 10 May 2018 20:24:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471051#comment-16471051
] 

Hadoop QA commented on ZOOKEEPER-1681:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3666//console

This message is automatically generated.

> ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep
as optional
> -------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1681
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
>            Reporter: John Sirois
>            Assignee: Stevo Slavic
>            Priority: Major
>             Fix For: 3.6.0, 3.5.5
>
>         Attachments: ZOOKEEPER-1681.patch
>
>
> For example in [3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
we see:
> {code}
> $ curl -sS http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
| grep -B1 -A4 org.jboss.netty
>     <dependency>
>       <groupId>org.jboss.netty</groupId>
>       <artifactId>netty</artifactId>
>       <version>3.2.2.Final</version>
>       <scope>compile</scope>
>     </dependency>
> {code}
> As a consumer I can depend on zookeeper with an exclude for org.jboss.netty#netty or
I can let my transitive dep resolver pick a winner.  This might be fine, except for those
who might be using a more modern netty published under the newish io.netty groupId.  With
this twist you get both org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath
and runtime errors ensue from incompatibilities. unless you add an exclude against zookeeper
(and clearly don't enable the zk netty nio handling.)
> I propose that this is a pom bug although this is debatable.  Clearly as currently packaged
zookeeper needs netty to compile, but I'd argue since it does not need netty to run, either
the scope should be provided or optional or a zookeeper-netty lib should be broken out as
an optional dependency and this new dep published by zookeeper can have a proper compile dependency
on netty.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message