zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Hunt <ph...@apache.org>
Subject Re: Let's cut a ZK 3.5.4-beta release
Date Tue, 08 May 2018 14:44:04 GMT
On Tue, May 8, 2018 at 1:58 AM, Flavio Junqueira <fpj@apache.org> wrote:

> Hi Pat,
>
> I'm ready to merge ZK-2982. It is a one line change that is actually a
> mistake that was made during the port of the changes from 3.4 to 3.5. It is
> just bringing in the line that was missed.
>
>
It looks like that was missed from 3.4, is that right? Sounds fine to me. I
will be cutting the release soon, so please get it in asap otw we might
miss the window.


> As you are the RM, I'll follow your instructions. I'm fine with either
> merging it today or doing a 3.5.5 immediately after. Let me know where you
> are with the release candidate and we can decide on the best course of
> action.
>
>
If you are confident with the fix and can get it in before I start 3.5.4
it's fine with me. Thanks!

Patrick



> -Flavio
>
> > On 8 May 2018, at 05:56, Patrick Hunt <phunt@apache.org> wrote:
> >
> > There's been plenty of time for someone to get these into 3.5.4 before
> now.
> > I really want to get 3.5.4 out so that folks can access/assess what's
> > currently committed.
> >
> > I'm happy to drive a follow-on release with these changes soon after
> 3.5.4
> > ships if there's sufficient progress.
> >
> > Patrick
> >
> > On Mon, May 7, 2018 at 2:00 PM, Alexander Shraer <shralex@gmail.com>
> wrote:
> >
> >> Lets also get this in: https://issues.apache.org/
> >> jira/browse/ZOOKEEPER-2959
> >> This affects anyone running observers.
> >>
> >> On Mon, May 7, 2018 at 1:45 PM, Flavio Junqueira <fpj@apache.org>
> wrote:
> >>
> >>> We should strongly consider merging this:
> >>>
> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2982
> >>>
> >>> As it is causing problems to anyone using ZK on K8s.
> >>>
> >>> -Flavio
> >>>
> >>>> On 7 May 2018, at 17:32, Rakesh Radhakrishnan <rakeshr@apache.org>
> >>> wrote:
> >>>>
> >>>> I have added my feedback to the PR. Please take a look at it.
> >>>>
> >>>>
> >>>> Rakesh
> >>>>
> >>>> On Mon, May 7, 2018 at 8:38 AM, Patrick Hunt <phunt@apache.org>
> wrote:
> >>>>
> >>>>> No one has looked at 2901, while I'm not super happy with it it
seems
> >>> fine
> >>>>> - I'll commit it as-is if I don't hear anything by EOD tomorrow
> >>> (Monday).
> >>>>> After which I'll start the release process.
> >>>>>
> >>>>> Patrick
> >>>>>
> >>>>> On Mon, Mar 26, 2018 at 2:09 AM, Andor Molnar <andor@cloudera.com>
> >>> wrote:
> >>>>>
> >>>>>> I'm currently working on ZOOKEEPER-2184. PR has been open for
ages
> on
> >>> 3.4
> >>>>>> branch, please review if you have some capacity.
> >>>>>> I'll port the fix to the 3.5 branch too, if we have an agreement
and
> >>>>>> 3.4-version is merged.
> >>>>>>
> >>>>>> ZK-2982 is somewhat related, I believe my changes will fix that
one
> >>> too.
> >>>>>>
> >>>>>> ZK-1818 is probably tough, but patch is already available. Somebody
> >>>>> should
> >>>>>> pick it up, which I'm happy to do once finished with above stuff.
> >>>>>>
> >>>>>> Regards,
> >>>>>> Andor
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Mon, Mar 26, 2018 at 3:39 AM, Michael Han <hanm@apache.org>
> >> wrote:
> >>>>>>
> >>>>>>> +1 on 3.5.4 release planning.
> >>>>>>>
> >>>>>>>>> There are 10 open blocker issues marked for 3.5.4.
Can I get some
> >>>>> help
> >>>>>>> to sort out those issues?
> >>>>>>>
> >>>>>>> The url posted does not work for me, here is the query I
use:
> >>>>>>> https://goo.gl/3MJZMN
> >>>>>>>
> >>>>>>> Just had a chance to go through the JIRA and did some clean
ups.
> >>>>>>> - 1159: lower the priority from blocker to major.
> >>>>>>> - 761: resolved because the code is merged.
> >>>>>>>
> >>>>>>> ZOOKEEPER-2903, 2184, 2982 looks like real blockers for
the 3.5.4
> >>>>>> release.
> >>>>>>> The rest of the blockers are legacy that's get postponed
> >> indefinitely.
> >>>>>>>
> >>>>>>>
> >>>>>>> On Wed, Mar 14, 2018 at 11:59 AM, Flavio Junqueira <fpj@apache.org
> >
> >>>>>> wrote:
> >>>>>>>
> >>>>>>>> Ok, I can have a look at ZK-2901. I'd like to get ZK-2982
in as
> >> well
> >>>>> as
> >>>>>>> it
> >>>>>>>> is causing us problems with Kubernetes. The fix is simple,
but I'm
> >>>>>>>> wondering about adding a test case.
> >>>>>>>>
> >>>>>>>> -Flavio
> >>>>>>>>
> >>>>>>>>> On 14 Mar 2018, at 17:30, Patrick Hunt <phunt@apache.org>
wrote:
> >>>>>>>>>
> >>>>>>>>> I would like to cut 3.5.4. Need more eyes on 2901
though.
> >>>>>>>>>
> >>>>>>>>> Patrick
> >>>>>>>>>
> >>>>>>>>> On Wed, Mar 14, 2018 at 4:26 AM, Flavio Junqueira
<
> fpj@apache.org
> >>>
> >>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> I think ZK-2901 is close to being merged, yes?
And with that,
> >> will
> >>>>>> we
> >>>>>>>> cut
> >>>>>>>>>> a 3.5.4 release?
> >>>>>>>>>>
> >>>>>>>>>> -Flavio
> >>>>>>>>>>
> >>>>>>>>>>> On 7 Dec 2017, at 00:27, Patrick Hunt <phunt@apache.org>
> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>> I haven't forgotten about this - we've been
stuck on
> >>>>> ZOOKEEPER-2901
> >>>>>>> . I
> >>>>>>>>>>> think we getting closer but it's been tricky
to navigate
> >>>>> addressing
> >>>>>>> the
> >>>>>>>>>>> issue vs backward compat vs making things
worse. I was about to
> >>>>>> sign
> >>>>>>>> off
> >>>>>>>>>>> then noticed I had missed something. Jordan
has been working to
> >>>>>>>> address.
> >>>>>>>>>>>
> >>>>>>>>>>> Camille, Edward -- it would be good if you
could take a look at
> >>>>>> 2901
> >>>>>>>>>> given
> >>>>>>>>>>> you participated in the original creation/commit
of this
> >> feature.
> >>>>>>>>>>>
> >>>>>>>>>>> Regards,
> >>>>>>>>>>>
> >>>>>>>>>>> Patrick
> >>>>>>>>>>>
> >>>>>>>>>>> On Tue, Nov 21, 2017 at 11:32 AM, Karan
Mehta <
> >>>>>>> karanmehta93@gmail.com>
> >>>>>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> Can we get ZOOKEEPER-2770
> >>>>>>>>>>>> <https://issues.apache.org/jira/browse/ZOOKEEPER-2770>
in as
> >>>>>> well?
> >>>>>>>> The
> >>>>>>>>>> PR
> >>>>>>>>>>>> is ready for review at https://github.com/apache/
> >>>>>> zookeeper/pull/307
> >>>>>>>>>>>> It will be a nice feature addition.
Thanks!
> >>>>>>>>>>>>
> >>>>>>>>>>>> Regards
> >>>>>>>>>>>> Karan
> >>>>>>>>>>>> ᐧ
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Tue, Nov 21, 2017 at 11:00 AM, Jordan
Zimmerman <
> >>>>>>>>>>>> jordan@jordanzimmerman.com> wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>>> Afaict the only real blocker
for the release at this point
> is
> >>>>>>>>>>>>>> ZOOKEEPER-2901 - Jordan can
you resolve the comments, after
> >>>>>> which
> >>>>>>> we
> >>>>>>>>>>>>> should
> >>>>>>>>>>>>>> be good to go. LMK if there's
anything I'm missing.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> I'll have this done in the next
day or so. Please wait for me
> >>>>> if
> >>>>>>> you
> >>>>>>>>>> can!
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> -Jordan
> >>>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>
> >>>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message