zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper issue #467: ZOOKEEPER-2968: Add C client code coverage tests
Date Thu, 31 May 2018 20:01:14 GMT
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/467
  
    +1 lgtm. I was able to run the coverage successfully and view the report. 
    
    possible followups:
    
    1) The report/results doesn't look great - only 50% coverage.
    
    2) I had to install lcov in order to run this. It would be a good idea to update the docs
- probably the c README - with details on how to run coverage and what the requirements are.
    
    3) What about the cmake build? Do we need to do anything there? (if not perhaps some docs?)


---

Mime
View raw message