zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...
Date Mon, 28 May 2018 17:55:35 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/451#discussion_r191252989
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java ---
    @@ -102,9 +102,9 @@ public void testBindByAddress() throws Exception {
             startSignal = new CountDownLatch(1);
             ZooKeeper zk = new ZooKeeper(HOSTPORT, CONNECTION_TIMEOUT, this);
             try {
    -            startSignal.await(CONNECTION_TIMEOUT,
    --- End diff --
    
    Sure, I agree. I think that was a suggestion from @afine and it's completely reasonable.


---

Mime
View raw message