zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log
Date Mon, 28 May 2018 14:11:30 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/307#discussion_r191205970
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -61,6 +61,7 @@
     
         private static boolean standaloneEnabled = true;
         private static boolean reconfigEnabled = false;
    +    private static int requestWarnThresholdMs = 10000;
    --- End diff --
    
    @karanmehta93 This feature sounds to me some kind of debugging / verbose monitoring feature
which should generally be turned off by default. If @hanm feels the same, I'll second that.
    
    However, if you want to implement a feature switch to this - which I think would be awesome
- use a dedicated bool config instead of some extraordinary threshold value. 


---

Mime
View raw message