zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #525: [ZOOKEEPER-3009] Potential NPE in NIOServerCnxn...
Date Mon, 21 May 2018 18:00:48 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/525#discussion_r189666458
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
    @@ -815,8 +815,11 @@ public void touchCnxn(NIOServerCnxn cnxn) {
             cnxnExpiryQueue.update(cnxn, cnxn.getSessionTimeout());
         }
     
    -    private void addCnxn(NIOServerCnxn cnxn) {
    +    private void addCnxn(NIOServerCnxn cnxn) throws IOException {
             InetAddress addr = cnxn.getSocketAddress();
    +        if (addr == null) {
    +            throw new IOException("Scoket of " + cnxn + " has been closed");
    --- End diff --
    
    fix the spelling.


---

Mime
View raw message