zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #523: ZOOKEEPER-3046: added junit timeout to precede ...
Date Sun, 20 May 2018 00:52:52 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/523#discussion_r189448291
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
---
    @@ -179,6 +180,8 @@ private void startServer(int id, String config) throws Exception {
             zkHandles[id] = ClientBase.createZKClient("127.0.0.1:" + clientPorts[id]);
             zkAdminHandles[id] = new ZooKeeperAdmin("127.0.0.1:" + clientPorts[id], CONNECTION_TIMEOUT,
this);
             zkAdminHandles[id].addAuthInfo("digest", "super:test".getBytes());
    +        LOG.info(String.format("Started server id %d with config:\n%s\nStat output:\n%s",
    +                id, config, FourLetterWordMain.send4LetterWord("127.0.0.1", clientPorts[id],
"stat")));
    --- End diff --
    
    Can you separate out the 4lw call onto it's own line?


---

Mime
View raw message