zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpj <...@git.apache.org>
Subject [GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...
Date Tue, 08 May 2018 11:01:03 GMT
Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/451#discussion_r186689865
  
    --- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
    @@ -53,7 +54,7 @@
          * @param spinDelay
          *            Milliseconds to wait if all hosts have been tried once.
          */
    -    public InetSocketAddress next(long spinDelay);
    +    public InetSocketAddress next(long spinDelay) throws UnknownHostException;
    --- End diff --
    
    My preference is the following:
    
    1- That we do not make this API change. It is not necessary to solve the problem of this
issue.
    2- That we discuss separately whether we want to change the behaviour of the `next()`
in the `HostProvider` interface.


---

Mime
View raw message