From dev-return-68905-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Apr 19 01:44:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3DD5F18064E for ; Thu, 19 Apr 2018 01:44:05 +0200 (CEST) Received: (qmail 48065 invoked by uid 500); 18 Apr 2018 23:44:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 48054 invoked by uid 99); 18 Apr 2018 23:44:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2018 23:44:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 864C8180617 for ; Wed, 18 Apr 2018 23:44:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id owcaEryFyr8P for ; Wed, 18 Apr 2018 23:44:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4F1F75F5FB for ; Wed, 18 Apr 2018 23:44:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C9560E0CBC for ; Wed, 18 Apr 2018 23:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2F85F241C6 for ; Wed, 18 Apr 2018 23:44:00 +0000 (UTC) Date: Wed, 18 Apr 2018 23:44:00 +0000 (UTC) From: "BELUGA BEHR (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ZOOKEEPER-3020) Review of SyncRequestProcessor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 BELUGA BEHR created ZOOKEEPER-3020: -------------------------------------- Summary: Review of SyncRequestProcessor Key: ZOOKEEPER-3020 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3020 Project: ZooKeeper Issue Type: Improvement Reporter: BELUGA BEHR Attachments: ZOOKEEPER.3020.1.patch # Use {{ArrayDeque}} instead of {{LinkedList}} # Use {{ThreadLocalRandom}} instead of {{Random}} # Remove the 'running' flag - use the {{Thread#join}} facility to detect if the thread has stopped running. Using a flag can cause race condition issues and is superfluous. # Make static final variable names in all caps # General cleanup {quote} This class is likely to be faster than Stack when used as a stack, and faster than LinkedList when used as a queue. {quote} https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)