From dev-return-69223-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Apr 25 14:12:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 189EB180676 for ; Wed, 25 Apr 2018 14:12:03 +0200 (CEST) Received: (qmail 87840 invoked by uid 500); 25 Apr 2018 12:12:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 87825 invoked by uid 99); 25 Apr 2018 12:12:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2018 12:12:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 862B21A1A20 for ; Wed, 25 Apr 2018 12:12:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 66df6V7rCTpD for ; Wed, 25 Apr 2018 12:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A7BB05F67B for ; Wed, 25 Apr 2018 12:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 287E4E0226 for ; Wed, 25 Apr 2018 12:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D7BC4241C8 for ; Wed, 25 Apr 2018 12:12:00 +0000 (UTC) Date: Wed, 25 Apr 2018 12:12:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16452134#comment-16452134 ]=20 ASF GitHub Bot commented on ZOOKEEPER-3019: ------------------------------------------- Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/501 =20 Removed fsyncExceed from stats command, but the tracking variable still= remains in ServerStats. I was thinking of moving it to for example zkDb, b= ut that wouldn't make any more sense in my opinion.=20 The other option is to leave it in FileTxnLog as a static variable, tha= t was my original idea actually.=20 So if that is a better solution, I will change it. > Add a metric to track number of slow fsyncs > ------------------------------------------- > > Key: ZOOKEEPER-3019 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx, server > Affects Versions: 3.5.3, 3.4.11, 3.6.0 > Reporter: Norbert Kalmar > Assignee: Norbert Kalmar > Priority: Major > Fix For: 3.5.4, 3.6.0, 3.4.13 > > > Add jmx bean and Command to ZooKeeper server to expose the the number of = slow fsyncs as a metric. > FileTxnLog.commit() should count the number of times fsync exceeds=C2=A0f= syncWarningThresholdMS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)