From dev-return-68706-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Apr 12 12:07:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2F35118067B for ; Thu, 12 Apr 2018 12:07:04 +0200 (CEST) Received: (qmail 91306 invoked by uid 500); 12 Apr 2018 10:07:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 91294 invoked by uid 99); 12 Apr 2018 10:07:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 10:07:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2D271C0D1D for ; Thu, 12 Apr 2018 10:07:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id nwI_6VWOjmwX for ; Thu, 12 Apr 2018 10:07:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DD4065F3CC for ; Thu, 12 Apr 2018 10:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6EF8AE0C25 for ; Thu, 12 Apr 2018 10:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1F69721209 for ; Thu, 12 Apr 2018 10:07:00 +0000 (UTC) Date: Thu, 12 Apr 2018 10:07:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16435275#comment-16435275 ]=20 ASF GitHub Bot commented on ZOOKEEPER-3019: ------------------------------------------- GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/501 ZOOKEEPER-3019 add metric for slow fsyncs count Added metric to count fsyncWarningThresholdMS exceed in FileTxnLog.comm= it(). Both jmx bean and Command can be used to get the stat. =20 Also updated the python standalone client and documentation. =20 Tested the py script, i.e.: src/contrib/monitoring/check_zookeeper.py -o cacti -s "localhost:2181" = -k zk_num_alive_connections localhost_2181:1 =20 rc/contrib/monitoring/check_zookeeper.py -o cacti -s "localhost:2181" -= k zk_fsync_threshold_exceed_count localhost_2181:0 =20 mntr command now returns: zk_version=093.6.0-SNAPSHOT-13c9f899ff62be6a2eacb28e522d06703f1dab08, b= uilt on 04/04/2018 12:09 GMT zk_avg_latency=090 zk_max_latency=090 zk_min_latency=090 zk_packets_received=097 zk_packets_sent=096 zk_num_alive_connections=091 zk_outstanding_requests=090 zk_server_state=09standalone zk_znode_count=095 zk_watch_count=090 zk_ephemerals_count=090 zk_approximate_data_size=0944 zk_open_file_descriptor_count=0961 zk_max_file_descriptor_count=0910240 zk_fsync_threshold_exceed_count=090 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3019 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/501.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #501 =20 ---- commit 8b575c879d45f28a34670bcb20cc4fd196dee008 Author: Norbert Kalmar Date: 2018-04-11T15:24:09Z ZOOKEEPER-3019 add metric to track slow fsyncs count + update py script= and docs ---- > Add a metric to track number of slow fsyncs > ------------------------------------------- > > Key: ZOOKEEPER-3019 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx, server > Affects Versions: 3.5.3, 3.4.11 > Reporter: Norbert Kalmar > Assignee: Norbert Kalmar > Priority: Major > > Add jmx bean and Command to ZooKeeper server to expose the the number of = slow fsyncs as a metric. > FileTxnLog.commit() should count the number of times fsync exceeds=C2=A0f= syncWarningThresholdMS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)