From dev-return-69300-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Apr 27 02:57:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D0E45180648 for ; Fri, 27 Apr 2018 02:57:04 +0200 (CEST) Received: (qmail 62494 invoked by uid 500); 27 Apr 2018 00:57:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 62480 invoked by uid 99); 27 Apr 2018 00:57:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2018 00:57:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 95C59CA1EC for ; Fri, 27 Apr 2018 00:57:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JMbJTGXVBibx for ; Fri, 27 Apr 2018 00:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 683B65FB37 for ; Fri, 27 Apr 2018 00:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 802D5E010F for ; Fri, 27 Apr 2018 00:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 368A620EAB for ; Fri, 27 Apr 2018 00:57:00 +0000 (UTC) Date: Fri, 27 Apr 2018 00:57:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16455613#comment-16455613 ]=20 Hadoop QA commented on ZOOKEEPER-3008: -------------------------------------- +1 overall. GitHub Pull Request Build =20 +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that = doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of java= c compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.= 0.1) warnings. +1 release audit. The applied patch does not increase the total number= of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-b= uild/1641//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github= -pr-build/1641//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings= .html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr= -build/1641//console This message is automatically generated. > Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthSer= ver#authenticate > -------------------------------------------------------------------------= ---------------- > > Key: ZOOKEEPER-3008 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3008 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.6.0 > Reporter: lujie > Priority: Major > > Inspired by ZK-3006 ,=C2=A0I develop a simple static analysis tool to fin= d other Potential NPE like ZK-3006. This bug is found by this tool ,and I h= ave carefully studied it.=C2=A0 But i am a=C2=A0newbie at here so i may be = wrong, hope someone=C2=A0could=C2=A0confirm it and help me=C2=A0improve thi= s tool. > h2. Bug=C2=A0description: > callee=C2=A0:SecurityUtils#createSaslClient will return null while=C2=A0e= ncounter exception > {code:java} > // code placeholder > catch (Exception e) { > LOG.error("Exception while trying to create SASL client", e); > return null; > } > {code} > but its caller has no null check just like: > {code:java} > // code placeholder > sc =3D SecurityUtils.createSaslClient(); > if (sc.hasInitialResponse()) { > responseToken =3D createSaslToken(new byte[0], sc, learnerLogin); > } > {code} > I think we should add null check in caller while callee return null -- This message was sent by Atlassian JIRA (v7.6.3#76005)