From dev-return-68909-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Apr 19 12:26:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8414E180638 for ; Thu, 19 Apr 2018 12:26:54 +0200 (CEST) Received: (qmail 3782 invoked by uid 500); 19 Apr 2018 10:26:48 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 3766 invoked by uid 99); 19 Apr 2018 10:26:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Apr 2018 10:26:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2F1BC1807DB for ; Thu, 19 Apr 2018 10:13:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Za7adAFhYPm6 for ; Thu, 19 Apr 2018 10:13:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 40F3F5F67B for ; Thu, 19 Apr 2018 10:13:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 39841E0CC1 for ; Thu, 19 Apr 2018 10:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A53C1241CF for ; Thu, 19 Apr 2018 10:13:00 +0000 (UTC) Date: Thu, 19 Apr 2018 10:13:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443826#comment-16443826 ] ASF GitHub Bot commented on ZOOKEEPER-2940: ------------------------------------------- Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182698169 --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java --- @@ -75,9 +79,9 @@ public void commandRun() { print("synced_followers", leader.getForwardingFollowers().size()); print("pending_syncs", leader.getNumPendingSyncs()); - print("last_proposal_size", leader.getProposalStats().getLastProposalSize()); - print("max_proposal_size", leader.getProposalStats().getMaxProposalSize()); - print("min_proposal_size", leader.getProposalStats().getMinProposalSize()); + print("last_proposal_size", leader.getProposalStats().getLast()); --- End diff -- You're right about stats will evolve with time, but proposal and client request size are common in Jute buffer usage. I have a strong feeling that these two things will always evolve together hence it makes sense to keep the stats together which also makes refactoring easier. Later, if it turns out that they diverge, we can easily split them. > Deal with maxbuffer as it relates to large requests from clients > ---------------------------------------------------------------- > > Key: ZOOKEEPER-2940 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server > Reporter: Andor Molnar > Assignee: Andor Molnar > Priority: Major > Fix For: 3.5.4, 3.6.0 > > > Monitor real-time Jute buffer usage as it relates to large requests from clients. -- This message was sent by Atlassian JIRA (v7.6.3#76005)