From dev-return-68962-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Apr 20 02:49:27 2018
Return-Path: <dev-return-68962-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id B8D8A180638
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 20 Apr 2018 02:49:26 +0200 (CEST)
Received: (qmail 51617 invoked by uid 500); 20 Apr 2018 00:49:25 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 51602 invoked by uid 99); 20 Apr 2018 00:49:24 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2018 00:49:24 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id BF818DFA3D; Fri, 20 Apr 2018 00:49:24 +0000 (UTC)
From: lavacat <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-500-zookeeper@git.apache.org>
In-Reply-To: <git-pr-500-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...
Content-Type: text/plain
Message-Id: <20180420004924.BF818DFA3D@git1-us-west.apache.org>
Date: Fri, 20 Apr 2018 00:49:24 +0000 (UTC)

Github user lavacat commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/500#discussion_r182922147
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long lastAcceptedEpoch) throws Interrupt
                 return epoch;
             }
         }
    -
    -    private HashSet<Long> electingFollowers = new HashSet<Long>();
    -    private boolean electionFinished = false;
    +    // VisibleForTesting
    +    protected HashSet<Long> electingFollowers = new HashSet<Long>();
    --- End diff --
    
    updated


---