From dev-return-68709-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Apr 12 14:25:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8E36F180634 for ; Thu, 12 Apr 2018 14:25:54 +0200 (CEST) Received: (qmail 50357 invoked by uid 500); 12 Apr 2018 12:25:53 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 50328 invoked by uid 99); 12 Apr 2018 12:25:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 12:25:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6085EE3652; Thu, 12 Apr 2018 12:25:52 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count Content-Type: text/plain Message-Id: <20180412122552.6085EE3652@git1-us-west.apache.org> Date: Thu, 12 Apr 2018 12:25:52 +0000 (UTC) Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181059907 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -146,6 +149,16 @@ public FileTxnLog(File logDir) { this.logDir = logDir; } + /** + * constructor for FileTxnLog. Take the directory + * where the txnlogs are stored + * @param logDir the directory where the txnlogs are stored --- End diff -- Description for `serverStats` param is missing. ---