From dev-return-68696-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Thu Apr 12 10:27:31 2018
Return-Path: <dev-return-68696-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-02.ponee.io (Postfix) with SMTP id 2303B520796
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 12 Apr 2018 10:27:30 +0200 (CEST)
Received: (qmail 40955 invoked by uid 500); 12 Apr 2018 08:27:30 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 40940 invoked by uid 99); 12 Apr 2018 08:27:29 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 08:27:29 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B74A6E3652; Thu, 12 Apr 2018 08:27:28 +0000 (UTC)
From: lavacat <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-500-zookeeper@git.apache.org>
In-Reply-To: <git-pr-500-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...
Content-Type: text/plain
Message-Id: <20180412082728.B74A6E3652@git1-us-west.apache.org>
Date: Thu, 12 Apr 2018 08:27:28 +0000 (UTC)

Github user lavacat commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/500#discussion_r181001854
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ---
    @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception {
                 recursiveDelete(tmpDir);
             }
         }
    +
    +    @Test
    +    public void testGetEpochToProposeWithObserver() throws Exception {
    +        File tmpDir = File.createTempFile("test", "dir", testData);
    +        tmpDir.delete();
    +        tmpDir.mkdir();
    +        Leader leader = null;
    +        try {
    +            QuorumPeer peer = createQuorumPeer(tmpDir);
    +            long participantId = 1;
    +            long observerId = peer.quorumPeers.size();
    +            peer.quorumPeers.put(observerId, new QuorumServer(observerId, "0.0.0.0", 33225,
    --- End diff --
    
    Do you mean using PortAssignment.unique() and "127.0.0.1"? Changed it.


---