zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3027) Accidently removed public API of FileTxnLog.setPreallocSize()
Date Fri, 27 Apr 2018 18:37:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456883#comment-16456883

ASF GitHub Bot commented on ZOOKEEPER-3027:

Github user phunt commented on the issue:

    +1, good catch. I committed this to all three active branches - please take a look at
3.4 branch commit as I did need to resolve a conflict. (seemed minor and tests are passing)

> Accidently removed public API of FileTxnLog.setPreallocSize()
> -------------------------------------------------------------
>                 Key: ZOOKEEPER-3027
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3027
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.4, 3.6.0, 3.4.13
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0, 3.4.13
> In my latest commit regarding TxnLogToolkit there's a refactor to outsource file padding
logic from FileTxnLog to a separate class:
> [https://github.com/apache/zookeeper/commit/126fb0f22d701cad58bf3123bf7d8f2219e60387#diff-89717124564925d61d29dd817bcdd915]
> Unfortunately public static method setPreallocSize(int) has also been moved to the new
class, but it's being actively used by hadoop-common project too:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/ClientBaseWithFixes.java#L384]
> I'd like to submit a patch to revert the deleted method which is going to call the new
one, but will keep backward compatibility with Hadoop.

This message was sent by Atlassian JIRA

View raw message