zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins
Date Tue, 24 Apr 2018 00:07:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449064#comment-16449064
] 

ASF GitHub Bot commented on ZOOKEEPER-3025:
-------------------------------------------

GitHub user andschwa opened a pull request:

    https://github.com/apache/zookeeper/pull/505

    ZOOKEEPER-3025: Make `hashtable` search `include`

    When ZOOKEEPER-2999 removed the directory side-effect of
    `include_directories(include)`, and added it as a target-level include
    to the `zookeeper` library, this broke the Windows build. It worked on
    Linux (where the patch was tested) because `winconfig.h` and is not
    included, but on Windows, the `hashtable` library included
    `winconfig.h` (found in `include`) but no longer knew where to find
    it. The fix is to add `include` to the `hashtable` library's list of
    include directories.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-3025

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #505
    
----
commit 69afce4df5a5cc71999d67c87578e236b58d17a1
Author: Andrew Schwartzmeyer <andrew@...>
Date:   2018-04-23T23:38:03Z

    ZOOKEEPER-3025: Make `hashtable` search `include`
    
    When ZOOKEEPER-2999 removed the directory side-effect of
    `include_directories(include)`, and added it as a target-level include
    to the `zookeeper` library, this broke the Windows build. It worked on
    Linux (where the patch was tested) because `winconfig.h` and is not
    included, but on Windows, the `hashtable` library included
    `winconfig.h` (found in `include`) but no longer knew where to find
    it. The fix is to add `include` to the `hashtable` library's list of
    include directories.

----


> cmake windows build is broken on jenkins
> ----------------------------------------
>
>                 Key: ZOOKEEPER-3025
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.5.4, 3.6.0
>            Reporter: Patrick Hunt
>            Assignee: Michael Han
>            Priority: Blocker
>             Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
fatal error C1083: Cannot open include file: 'winconfig.h': No such file or directory [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins build broken
on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — [hanm|https://builds.apache.org/user/hanm/] / [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — [hanm|https://builds.apache.org/user/hanm/] / [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message