zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ZOOKEEPER-3020) Review of SyncRequestProcessor
Date Wed, 18 Apr 2018 23:44:00 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

BELUGA BEHR updated ZOOKEEPER-3020:
-----------------------------------
    Attachment: ZOOKEEPER.3020.1.patch

> Review of SyncRequestProcessor
> ------------------------------
>
>                 Key: ZOOKEEPER-3020
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3020
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Priority: Minor
>         Attachments: ZOOKEEPER.3020.1.patch
>
>
> # Use {{ArrayDeque}} instead of {{LinkedList}}
> # Use {{ThreadLocalRandom}} instead of {{Random}}
> # Remove the 'running' flag - use the {{Thread#join}} facility to detect if the thread
has stopped running.  Using a flag can cause race condition issues and is superfluous.
> # Make static final variable names in all caps
> # General cleanup
> {quote}
> This class is likely to be faster than Stack when used as a stack, and faster than LinkedList
when used as a queue.
> {quote}
> https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message