zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients
Date Wed, 18 Apr 2018 14:59:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442637#comment-16442637

ASF GitHub Bot commented on ZOOKEEPER-2940:

Github user anmolnar commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java ---
    @@ -75,9 +79,9 @@ public void commandRun() {
                 print("synced_followers", leader.getForwardingFollowers().size());
                 print("pending_syncs", leader.getNumPendingSyncs());
    -            print("last_proposal_size", leader.getProposalStats().getLastProposalSize());
    -            print("max_proposal_size", leader.getProposalStats().getMaxProposalSize());
    -            print("min_proposal_size", leader.getProposalStats().getMinProposalSize());
    +            print("last_proposal_size", leader.getProposalStats().getLast());
    --- End diff --
    Agreed, javadoc is misleading.
    Actually I wanted to keep these two things together and would like to refactor both in
a later commit. They refer to the same thing basically, exposing statistics on Jute buffer
usage which is a feed of int values. I'm happy to find a better name for the class, but wouldn't
create a separate one for almost the same purpose.
    What do you think of `BufferStats`?

> Deal with maxbuffer as it relates to large requests from clients
> ----------------------------------------------------------------
>                 Key: ZOOKEEPER-2940
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0
> Monitor real-time Jute buffer usage as it relates to large requests from clients.

This message was sent by Atlassian JIRA

View raw message