zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.
Date Mon, 23 Apr 2018 15:30:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448307#comment-16448307
] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
-------------------------------------------

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/338#discussion_r183430034
  
    --- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java ---
    @@ -168,4 +169,41 @@ private static void visitSubTreeDFSHelper(ZooKeeper zk, final String
path,
                 return; // ignore
             }
         }
    +
    +    /**
    +     * @param perms
    +     *            ACL permissions
    +     * @return string representation of permissions
    +     */
    +    public static String getPermString(int perms) {
    --- End diff --
    
    Have you considered caching these values in some way?
    I see 2 options to make this faster:
    1. dynamic caching of already generated values,
    2. static caching of all possible values in a static hashmap (32 possible values if I'm
not mistaken)


> Audit logging in ZooKeeper servers.
> -----------------------------------
>
>                 Key: ZOOKEEPER-1260
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: server
>            Reporter: Mahadev konar
>            Assignee: Mohammad Arshad
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0
>
>         Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode and what
updates went through a znode. We should add audit logging as in Hadoop (look at Namenode Audit
logging) to log which client changed what in the zookeeper servers. This could just be a log4j
audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message