zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count
Date Fri, 27 Apr 2018 12:01:58 GMT
Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r184667238
  
    --- Diff: src/contrib/monitoring/check_zookeeper.py ---
    @@ -256,6 +261,36 @@ def _parse_stat(self, data):
                     result['zk_znode_count'] = int(m.group(1))
                     continue
     
    +            m = re.match('Watch count: (\d+)', line)
    +            if m is not None:
    +                result['zk_watch_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Ephemerals count: (\d+)', line)
    +            if m is not None:
    +                result['zk_ephemerals_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Approximate data size: (\d+)', line)
    +            if m is not None:
    +                result['zk_approximate_data_size'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Open file descriptor count: (\d+)', line)
    +            if m is not None:
    +                result['zk_open_file_descriptor_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Max file descriptor count: (\d+)', line)
    +            if m is not None:
    +                result['zk_max_file_descriptor_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Fsync threshold exceeded: (\d+)', line)
    --- End diff --
    
    Yes, thats for stat command, thanks. I changed it and tested the py scripts, looks good
now.


---

Mime
View raw message