zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lujiefsi <...@git.apache.org>
Subject [GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...
Date Thu, 26 Apr 2018 01:49:40 GMT
Github user lujiefsi commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/496#discussion_r184251756
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
    @@ -94,7 +94,10 @@ public void authenticate(Socket sock, String hostName) throws IOException
{
                         principalConfig,
                         QuorumAuth.QUORUM_SERVER_PROTOCOL_NAME,
                         QuorumAuth.QUORUM_SERVER_SASL_DIGEST, LOG, "QuorumLearner");
    -
    +            if (sc == null) {
    --- End diff --
    
    For #1:
    Follower#77,Observer#69,QuorumCnxManager#333 all have same patern:
    `try { //root caller } catch (IOException e) {//handler code}`
    #2 and #3, @brettKK .


---

Mime
View raw message