zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...
Date Wed, 25 Apr 2018 21:15:18 GMT
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/495
  
    Ok, that (call site analysis) makes sense. 
    
    I'm afraid I was unclear, when I said
    
    "You don't need an ERROR in the text here or on the next line."
    
    What I mean is that the text string should not start with "ERROR" given the error string
is in an exception and the logging (from one of the callers) will determine the severity to
assign. As such my recommendation would be something like:
    
    > throw new RuntimeException("Incorrect format of InputArchive when deserialize DataTree
- missing acls");
    
    Notice: 1) the removal of "ERROR" and the addition of "missing acls" in order to give
the person diagnosing the problem a bit more insight (otw they have to find the source line
in order to get more insight into what they formatting issue might be).
    
    If you clear this up (this one line) I think we should be good for commit.
    
    Thanks!


---

Mime
View raw message