zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count
Date Wed, 25 Apr 2018 08:37:53 GMT
Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r183980318
  
    --- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java ---
    @@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
             line = in.readLine();
             Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
             line = in.readLine();
    +        Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded: \\d+$", line));
    --- End diff --
    
    Yes, it would have been an ugly solution, that's why I didn't go ahead with it.
    Okay, sounds good to me, I will make the changes.
    
    Thanks!


---

Mime
View raw message